Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Hash password for website #10

Closed
MartinVingerhoets opened this issue Jun 2, 2019 · 4 comments
Closed

Hash password for website #10

MartinVingerhoets opened this issue Jun 2, 2019 · 4 comments
Labels
critical This issue describes a problem that impedes the applications basic function enhancement New feature or request

Comments

@MartinVingerhoets
Copy link
Contributor

MartinVingerhoets commented Jun 2, 2019

Could you make it so the password you enter in the website is hashed because it is currently being send in plain text which isn't a good idea.

@themoonisacheese themoonisacheese added critical This issue describes a problem that impedes the applications basic function enhancement New feature or request labels Jun 3, 2019
@sijanec
Copy link

sijanec commented Sep 25, 2019

A hash would not help. A hash with a nonce would, but it is still not advised to connect to this website from the Internet because it has no SSL. SSL would be just a ridiculous overkill for this project.

A safe connection to the website would be via a SSH tunnel to your host (encrypted).

And remember: if someone else has user access to your host, or if you have a website with many features that is subject to directory traversal and arbitrary file read, make sure to chmod 700 -R . your 2bored2wait directory so others won't be able to read your MINECRAFT ACCOUNT data! There is no way to store a hash of it on the host.

@NBTX
Copy link

NBTX commented Nov 30, 2019

@sijanec It's not necessary to implement SSL into the application itself, you can use an NGINX (or some other) reverse proxy that you expose to the public-facing internet which implements SSL.

@NBTX
Copy link

NBTX commented Nov 30, 2019

Also, regarding the Minecraft account, I think when you start the application, you should input your Minecraft password into the website.

One feature I may look at implementing is seeing if we can grab the user's authentication token straight from the client by default, so we don't even normally need to enter the password into the file. (Obviously this won't work if you aren't running the server locally, but I imagine this will allow a significant chunk of people to avoid entering their password.)

@MrGeorgen
Copy link
Collaborator

@sijanec It's not necessary to implement SSL into the application itself, you can use an NGINX (or some other) reverse proxy that you expose to the public-facing internet which implements SSL.

good solution

@MrGeorgen MrGeorgen mentioned this issue Mar 15, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical This issue describes a problem that impedes the applications basic function enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants