Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity Forms not working #220

Closed
dstollie opened this issue Oct 28, 2015 · 7 comments
Closed

Gravity Forms not working #220

dstollie opened this issue Oct 28, 2015 · 7 comments
Milestone

Comments

@dstollie
Copy link

For most of our projects we use gravity forms to create our forms. But when using themosis together with it. The editor of Gravity Forms suddenly breaks. Can someone help us out?

@jlambe
Copy link
Contributor

jlambe commented Oct 28, 2015

Do you have any error message in the console, log files or on screen when using Gravity?

@dstollie
Copy link
Author

Thats the problem, no I havent. Activiting of the plugin goes just succesfully. Creating a new form also. But whenever I go to the editor the right sidebar is not showing up. In Gravity Forms its also possible to import existing forms but chaning those fields (in the main part, not the sidebar) is also not possible

@jlambe
Copy link
Contributor

jlambe commented Oct 28, 2015

I've never used Gravity forms. What happens if your remove the framework from the mu-plugins? is the gravity form plugin working correctly after that?

@dstollie
Copy link
Author

yes it is. I think it has something to do with themosis overwriting some content which gravity forms adds using filters/actions

@jlambe
Copy link
Contributor

jlambe commented Oct 28, 2015

I was thinking the same. Version 1.1.3 is using some actions/filters to bootstrap which may create conflicts.
For next release 1.2.0, all these filters/actions are removed. This next release is currently on master branches. Which version do you use? If you can, perhaps test with current master branch version of the framework and see if there are still conflicts with Gravity forms.

@dstollie
Copy link
Author

Weve fixed it! The problem was completely our fault:

We had this in our supports.config.php

    /* --------------------------------------------------------------- */
    // Enable post thumbnails
    /* --------------------------------------------------------------- */
    'post-thumbnails',
    /* --------------------------------------------------------------- */
    // Enable post formats (aside, gallery, link, image, ...)
    /* --------------------------------------------------------------- */
    'post-formats',

But this causes problems. This fixes it:

    /* --------------------------------------------------------------- */
    // Enable post thumbnails
    /* --------------------------------------------------------------- */
    'post-thumbnails' => [],
    /* --------------------------------------------------------------- */
    // Enable post formats (aside, gallery, link, image, ...)
    /* --------------------------------------------------------------- */
    'post-formats' => [],

Maybe adding a check if these keys do have arrays, will be a good improvement?

@jlambe
Copy link
Contributor

jlambe commented Oct 28, 2015

Glad the issue is solved. I have to check if all keys need an array or not. If there is a change it could come to version 1.2.1 as a minor fix.

@jlambe jlambe closed this as completed Oct 28, 2015
@jlambe jlambe added this to the 1.2.1 milestone Oct 28, 2015
@jlambe jlambe reopened this Oct 28, 2015
@jlambe jlambe closed this as completed in 8505c19 Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants