Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option 'use24Hour' not compatible to be set using data- notation in html #92

Closed
robotdan opened this issue Oct 25, 2011 · 1 comment
Closed

Comments

@robotdan
Copy link

This isn't really a bug but more of a feature request I suppose.

The calendar option 'use24Hour' because does not seem to be compatible with the data- notation to embed options in html.
( doc https://github.com/themouette/jquery-week-calendar/wiki/Script-options )

I'd like to be able to allow a user to change this default option by specifying the data- value in the div tag.

Example:

 <div class="week-calendar" data-use24-Hour="false" />

This doesn't work, I believe it because of the 24.

If the option were changed to be 'useTwentyFourHour' then I think it would work and could be described in html as

 <div class="week-calendar" data-use-twenty-four-hour="false" />
@robotdan
Copy link
Author

robotdan commented May 8, 2013

I think this issue was related to a jQuery bug, looks to be fixed in 1.6.4 and later.
http://bugs.jquery.com/ticket/9318

Examples of use24Hour data- notation in jsfiddle:
1.6.1 broken http://jsfiddle.net/mcHHu/6/
1.6.4 fixed http://jsfiddle.net/mcHHu/5/

@robotdan robotdan closed this as completed May 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant