Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHP 8.2 and packages #57

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

roberto-butti
Copy link

  • upgrade and check with PHP 8.2
  • upgrade code using new renderer of Commonmark
  • upgrade GitHub Actions workflow
  • using Pint with PSR12
  • added configuration for cover image (instead of using hardcoded cover.jpg, you can specify a new file name and format, for example, my-cover.png)

@dcblogdev
Copy link
Contributor

would be great to get this merged.

@edwinheij
Copy link

edwinheij commented Mar 24, 2023

  • upgrade and check with PHP 8.2
  • upgrade code using new renderer of Commonmark
  • upgrade GitHub Actions workflow
  • using Pint with PSR12
  • added configuration for cover image (instead of using hardcoded cover.jpg, you can specify a new file name and format, for example, my-cover.png)

And adds support for Laravel v10

Can this be merged?

Copy link

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be nice to get this merged 🙌

@sajaddp
Copy link

sajaddp commented May 14, 2023

@themsaid Can you please merge it?

@roberto-butti
Copy link
Author

Good morning Mohamed @themsaid .
I know you are super busy, and this project is great and very helpful.
I would like to know if you have any plans to upgrade this wonderful project with the latest packages.
I would like to understand how I can be of support or help (if necessary) in the maintenance of this project.

Thank you! 🙏

Roberto

@bobbyiliev
Copy link

Good morning Mohamed @themsaid . I know you are super busy, and this project is great and very helpful. I would like to know if you have any plans to upgrade this wonderful project with the latest packages. I would like to understand how I can be of support or help (if necessary) in the maintenance of this project.

Thank you! 🙏

Roberto

I would love to offer my help as well! I love the tool, it has allowed me to publish 5+ books so far 🙏

image

@dcblogdev
Copy link
Contributor

@roberto-butti can you release your fork? It would be amazing to have an installable version.

@hamidafghan
Copy link

@themsaid Any plan to have a quick review of this PR and merge. Thanks

@roberto-butti
Copy link
Author

I'm available to publish the package from the forked repo, but i think is better and fair to wait Mohamed.

@tnylea
Copy link

tnylea commented Oct 10, 2023

In case someone wants to use the version that @roberto-butti

I've added a temporary working version here: https://github.com/thedevdojo/ibis

You can install with: composer global require thedevdojo/ibis

I will remove this package when it's no longer necessary and this gets merged in, but until then, you can use this version with the latest version of Laravel 😉

@hamidafghan
Copy link

Thank you @tnylea, Let's hope @themsaid sees the comments and merges the PR. :)

@roberto-butti
Copy link
Author

Hi Folks, on top of this PR, i created the PHP8.3 Pull request.
Based on the PHP 8.2 changes, PHP 8.3 doesn't introduce changes; just adjusted the GitHub Workflow for the CI just to check the PHP8.3 execution
#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants