Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It cannot find my languages #5

Closed
meness opened this issue Apr 27, 2017 · 5 comments
Closed

It cannot find my languages #5

meness opened this issue Apr 27, 2017 · 5 comments

Comments

@meness
Copy link

meness commented Apr 27, 2017

Hi,

My base language is fa, and the English lang path is /resources/lang/en/ but the tool continually says:

There are no JSON translation keys in your project, start by creating JSON
files for every language in your "resources/lang" directory.

In case you have the files already created, you may now start adding keys or
let Langman scan your project for lines to translate.

@SkifAlef
Copy link

You have to create fa.json and en.json directly in /resources/lang directiory, not in /resources/lang/en and /fa subdirectories

@meness meness closed this as completed Apr 27, 2017
@SkifAlef
Copy link

Well, this is the idea of json-based localization as I see it. When number of strings to localize grows over some margin it's actually more convenient to stop structure them at all, 'cause overhead for maintaing it is too much.

Anyway, you can still totally use classic non-json method with /lang/locale/file.php files.

@meness
Copy link
Author

meness commented Apr 27, 2017

@SkifAlef You're right about the new JSON-based localization way. What about already provided strings with Laravel (e.g. validation.php)? Should I also put them inside JSON files?

@SkifAlef
Copy link

Well, it's totally up yo you, there's no some proper way to do it.
I'd leave 'em as they be, 'cause usually you just one time localize those strings and forget about 'em

@meness
Copy link
Author

meness commented Apr 28, 2017

@SkifAlef Thanks for the help ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants