Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-directories translations #3

Closed
vpratfr opened this issue Apr 3, 2016 · 4 comments
Closed

Sub-directories translations #3

vpratfr opened this issue Apr 3, 2016 · 4 comments

Comments

@vpratfr
Copy link

vpratfr commented Apr 3, 2016

3rd party packages sometimes allow to publish translation files.

Those file are usually located inside a subfolder of lang. For instance:

lang
  |_ en
  |_ fr
  |_ es
  |_ vendor
    |_ package1
    | |_ en
    | |_ fr
    | |_ es
    |_ package2
      |_ en
      |_ es
  • Is that supported by your tool?
  • Will package1/package2 get updated too?
  • Will fr be created in package2 folder?
@themsaid
Copy link
Owner

themsaid commented Apr 3, 2016

That's not supported at the moment, also nested keys:

'names' =>['first' => 'first name', 'last' => 'last name']

Both are not supported yet. I'm planning to work on that sometime soon, I'll appreciate contributions though.

@vpratfr
Copy link
Author

vpratfr commented Apr 3, 2016

Oh. Ok. I guess the vendor package issue could be worked around by allowing multiple paths in your config file and ditching all folders with name having more than 2 characters.

Nested keys is a rather big problem too, that's very common to have nested keys in translation files (that includes the default files provided by Laravel)

@themsaid
Copy link
Owner

themsaid commented Apr 3, 2016

yes, these two cases need to be covered, I'll put some time for them during this week :) Hopefully can come up with something soon.

@themsaid themsaid changed the title Vendor translations Sub-directories translations Apr 4, 2016
@themsaid
Copy link
Owner

themsaid commented Apr 9, 2016

The package now supports dealing with vendor translation files since v1.2.0 https://github.com/themsaid/laravel-langman/releases/tag/v1.2.0

@themsaid themsaid closed this as completed Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants