Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q&A #9

Open
thenaim opened this issue Sep 28, 2020 · 17 comments
Open

Q&A #9

thenaim opened this issue Sep 28, 2020 · 17 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@thenaim
Copy link
Owner

thenaim commented Sep 28, 2020

No description provided.

@Snowbases
Copy link

Hello @thenaim. This template app is really cool.
I have some question about components,
why you didnt make a component module instead?

@thenaim
Copy link
Owner Author

thenaim commented Jul 11, 2021

@Snowbases, The main reason is the lack of free time (since I work) to implement this approach, but in the code I try to separate templates into components and modules (angular).

upd: There are plans for such an approach, but if you have a desire to work on it, we can organize it.

@nguoianphu
Copy link
Collaborator

Hello @thenaim ,
Thank you so much for a great app. 👍
Could you please tell me how to run it and log in? I can build and run it by npm run start, but I don't know how to log in or register. Is there any demo account to use?

@thenaim
Copy link
Owner Author

thenaim commented Jul 11, 2021

@nguoianphu, you can use any valid email address and a password of at least 6 characters

@nguoianphu
Copy link
Collaborator

Thanks @thenaim, got it. I'm able to build & run it on web. I also can build it on Github action & generate APKs to Release. However, the app seems slow when running on Android...

@thenaim
Copy link
Owner Author

thenaim commented Jul 11, 2021

@nguoianphu, Did you compile the production version of angular (ionic), and also compile for android (apk)? If not, then the application will be slow to work, as many plugins and helper functions in the dev version are running under the hood.

And also the application requires a lot of optimization, so if there is a desire to work on this, then welcome)

@thenaim thenaim added enhancement New feature or request question Further information is requested labels Jul 11, 2021
@nguoianphu
Copy link
Collaborator

Yes, I've compiled it in production mode. Please check my Github action. BTW, I'm learning React & Ionic so I'm not interested in Angular. :)
https://github.com/nguoianphu/ionic-tk-social-network/releases

@thenaim
Copy link
Owner Author

thenaim commented Jul 11, 2021

@nguoianphu, I just checked the apk on a real device. It really works slowly, but as I wrote above, it is necessary to optimize the interaction with the server. Such as pagination, preloading modules, requesting the server after full rendering, etc. First of all, I will deal with this. Thank you.

I see you worked with github actions, do you want to work and do PR, where all this will be set up for this project? To configure action for all PR`s for main branch.

@nguoianphu
Copy link
Collaborator

@thenaim , just see you added actions to deploy the web version automatically. It's great 👍 !

But it looks like we deploy the web version from main branch, instead of web. Does it make sense?

@thenaim
Copy link
Owner Author

thenaim commented Jul 15, 2021

@nguoianphu, Thank you. This is done to avoid committing www changes to the main branch every time and the web version is always separated from the main branch. Or do you have an idea?

upd: In ionic, during development, the live version will be constantly launched, as well as with many options, so when sending a commit, there may be conflicts in the code (www folder). In this situation, you will need to compile locally and send a commit. Maybe I misunderstood, correct me.

@thenaim thenaim pinned this issue Jul 15, 2021
@nguoianphu
Copy link
Collaborator

Oh, I was wrong -_-. Never mind, sorry.

@thenaim
Copy link
Owner Author

thenaim commented Jul 15, 2021

@nguoianphu, It's okay, I thought about this task for a long time)

@thenaim
Copy link
Owner Author

thenaim commented Jul 15, 2021

@nguoianphu, I have a question for you, how we can optimize github actions? Can we somehow separate them, or into some stages? Any ideas?

@nguoianphu
Copy link
Collaborator

@thenaim , exactly what I want to do.
Please refer this, I like it and plan to apply: https://github.com/zyrouge/yukino-app/actions

@thenaim
Copy link
Owner Author

thenaim commented Jul 15, 2021

@nguoianphu, Yes, this approach is very good. for example, first of all, run the code check (eslint), if no errors, then the rest of the actions. I think you already understood the concept.

@nguoianphu
Copy link
Collaborator

@thenaim , can you register this repo to https://www.codefactor.io? Then we can have badge for it. If it's ok, I will open a PR for this commit.

@thenaim
Copy link
Owner Author

thenaim commented Jul 16, 2021

Hi, @nguoianphu, good idea. Yes, just now registered.

@thenaim thenaim self-assigned this Jul 28, 2021
@thenaim thenaim unpinned this issue Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants