Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of Questions. #11

Closed
ATMmachin3 opened this issue Sep 2, 2021 · 11 comments
Closed

Couple of Questions. #11

ATMmachin3 opened this issue Sep 2, 2021 · 11 comments

Comments

@ATMmachin3
Copy link

ATMmachin3 commented Sep 2, 2021

Hi, while setting this up on my server, I have a few questions which you can take your time answering.

  • In map_(name).yml on line 16, could you explain what 'attacker_block_prot_minute_z: (n)' Means in terms of protection which way does the protection occur from
  • Is there multi map support, I see it on the roadmap, but is there any half completed support or not.
  • Why are all the max & min's in Z, do the maps have to be oriented in this way to work.

Then 3 basic requests

  • Can you add a config option for the assault command /help to not override normal /help if you have a permission?
  • Add more game modifiers like First to 5 (stars) or Most stars in 8 minutes
  • Options for multiple defender spawnpoints
@TheNathanSpace
Copy link
Owner

TheNathanSpace commented Sep 2, 2021

In map_(name).yml on line 16, could you explain what 'attacker_block_prot_minute_z: (n)' Means in terms of protection which way does the protection occur from

That z-value is the minimum z-value that defenders can go on the map. It's basically spawn protection for the attackers. Looking at it, it's kind of named strangely—I just renamed it to attacker_base_prot_max_z.

Is there multi map support, I see it on the roadmap, but is there any half completed support or not.

As-is there isn't support for multiple maps. I didn't finish it because I didn't have a second map ready. I just finished up the code so that you can add your own maps, latest jar here: https://github.com/TheKingElessar/Assault/releases/tag/v0.11.2

I haven't had a chance to test it, but it was a very small change, so hopefully it works fine.

Why are all the max & min's in Z, do the maps have to be oriented in this way to work.

Yeah, the maps do have to be oriented like that. That's just how I set it up. If you have a problem with it let me know and I can see what I can do!


Your 3 requests are very good ideas, I'd definitely like to do them. I might just rename the help command so I don't have to deal with that.

@ATMmachin3
Copy link
Author

Wow, Thanks so much. This is very helpful

@ATMmachin3
Copy link
Author

Oh and no problem with the Z, if I ever mess it up I have WorldEdit to save me

@TheNathanSpace
Copy link
Owner

TheNathanSpace commented Sep 2, 2021

If you do end up making any maps please do let me know! I'd love see what you come up with. :)

Edit: Note that when you start a game, it chooses a random map from the list in config.yml. So you can do what you want with that.

Edit 2: Keep in mind that since attacker_base_prot_max_z is one value for both bases in a map, the two sides of the map should be oriented in the same direction.

@ATMmachin3
Copy link
Author

I have been working on some maps, not exactly sure of their playabilty but I will test them out with my friends.

that is useful to know

I figured that out when I climbed over the wall and ran into the attacker area

@ATMmachin3
Copy link
Author

ATMmachin3 commented Sep 2, 2021

Thanks again
Edit:
On your to-do list there is actual documentation, I could help with that, I'll see how my time is.
and, you need to update the roadmap to exclude multiple map support as that is already a feature now!

Edit 2: Gonna fork it now and start on documentation.

@TheNathanSpace
Copy link
Owner

That sounds awesome! I'll try and work on some more features and fixes we've talked about.

@ATMmachin3
Copy link
Author

ATMmachin3 commented Sep 2, 2021

Thanks, also I have realised after writing 3 pages of documentation you cannot open a pull request for a wiki page.

Edit: So for me to work on the wiki you would either have to make me a collaborator in wiki settings or just download https://github.com/ATMmachin3/Assault.wiki.git and copy paste what I have done so far

Edit 2: It might be easier to enable GitHub discussions rather then constantly posting here

@ATMmachin3
Copy link
Author

ATMmachin3 commented Sep 2, 2021

I'll create a branch called docs on my fork and move documentation there then pr that. I guess you could use a GitHub Pages for it.

Edit: Undone all I did, #12 Explains

@TheNathanSpace
Copy link
Owner

I've just enabled GitHub discussions (never used it so hopefully did it right) here: https://github.com/TheKingElessar/Assault/discussions/15

I invited you as a collaborator, but then I found the setting that lets everyone edit the wiki, so hopefully that works now if it's something you want to do! Let me know if I should do anything for that (copy stuff over, etc.).

@ATMmachin3
Copy link
Author

Ok, It seems all is fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants