Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for primitive object wrappers (fixes #295) #296

Merged
merged 4 commits into from
May 30, 2021
Merged

Added support for primitive object wrappers (fixes #295) #296

merged 4 commits into from
May 30, 2021

Conversation

smares
Copy link
Contributor

@smares smares commented May 28, 2021

Added support for primitive object wrappers (fixes #295)

goloroden
goloroden previously approved these changes May 29, 2021
@goloroden goloroden self-requested a review May 29, 2021 11:25
@goloroden
Copy link
Member

Hi @smares 👋

Thanks a lot for coming up with this PR 😊
The changes look good, however, there a few things that need to changed.

First, code analysis now fails – you can see this when you run npx roboter on your machine. Can you please disable the rules for the affected lines using eslint-disable-next-line?

Second, the documentation should be updated as well. It's probably enough to have one sentence pointing out that it also works with the object wrappers, however it would be great if you could add this to the README.md file.

Last but not least, I wanted to ask if you would like to add yourself to the list of contributors in the package.json file?

@goloroden goloroden self-assigned this May 29, 2021
@smares
Copy link
Contributor Author

smares commented May 29, 2021

When I run npx roboter on my Windows machine, this is the output I get:

────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
▸ Running quality assurance...
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
▸ Running code analysis...

Oops! Something went wrong! :(

ESLint: 7.26.0

No files matching the pattern "'lib/boolean.ts'" were found.
Please check for typing mistakes in the pattern.

✗ Malformed code found.
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
  Code malformed.
  Error: Code malformed.
    at analyseTask (C:\Users\Sebastian\Documents\Projekte\boolean\node_modules\roboter\lib\cli\tasks\analyse.js:25:15)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Object.run (C:\Users\Sebastian\Documents\Projekte\boolean\node_modules\roboter\lib\cli\commands\qa.js:38:5)
    at async C:\Users\Sebastian\Documents\Projekte\boolean\node_modules\roboter\lib\bin\roboter.js:113:5
⠋

That No files matching the pattern "'lib/boolean.ts'" were found. line is weird, I am running roboter from the project root.

Not sure if this is caused by the previous line, but I can't seem to get rid of the ✗ Malformed code found.. Tried with both // eslint-disable-next-line no-new-wrappers unicorn/new-for-builtins and // eslint-disable-next-line.

Any idea what I am doing wrong?

Updated readme to reflect the added support for primitive object wrappers.
Updated package.json to include myself as contributor.
@goloroden
Copy link
Member

@smares Well, we do not currently support running roboter on Windows, so it may just be that it doesn't work because of the OS. (However, we will change this in the next version, which is currently under development.)

So, thanks for the updates, I'll have a look at them, and get back to you as soon as possible 😊

goloroden
goloroden previously approved these changes May 30, 2021
@goloroden goloroden merged commit 5ae115f into thenativeweb:main May 30, 2021
@goloroden
Copy link
Member

@smares I've just added a few missing commas, and merged it now – will be live on npm in a few minutes. Thanks once again for all your work 😊

goloroden pushed a commit that referenced this pull request May 30, 2021
# [3.1.0](3.0.4...3.1.0) (2021-05-30)

### Features

* Add support for primitive object wrappers (fixes [#295](#295)) ([#296](#296)) ([5ae115f](5ae115f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong result with primitive object wrappers
2 participants