feat: Hydrate CustomError and Result. #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeldiRium
requested review from
dotKuro,
goloroden and
strangedev
as code owners
goloroden
requested changes
Oct 22, 2021
There was a problem hiding this comment.
Hey @yeldiRium 👋
I finally had the time to review your changes. Please find my notes inline 😊
strangedev
suggested changes
Feb 22, 2022
There was a problem hiding this comment.
Nice work, I like the idea. I have some questions regarding the details though, if you could please take a look @yeldiRium 🙂
yeldiRium
force-pushed
the
feat/hydrate-error-and-result
branch
from
5e3c9b6
to
e0d30e4
Compare
goloroden
approved these changes
Feb 22, 2022
goloroden
pushed a commit
that referenced
this pull request
Feb 22, 2022
# [8.2.0](8.1.0...8.2.0) (2022-02-22) ### Features * Hydrate CustomError and Result. ([#344](#344)) ([3f4343c](3f4343c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC @dotKuro @goloroden @strangedev
As discussed with @strangedev via slack, I needed a way to hydrate Errors and Results that were JSON-serialized before. That means multiple things:
Result<undefined, ...>is represented in JSON as an empty objectPlease take a look at the implementations and the documentation and reasoning for them and leave some feedback on wether you think this solution makes sense. Until I get some feedback I'll leave this as a draft.