Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate over to using thenewboston-js repo #585

Open
angle943 opened this issue Mar 4, 2021 · 13 comments
Open

Migrate over to using thenewboston-js repo #585

angle943 opened this issue Mar 4, 2021 · 13 comments

Comments

@angle943
Copy link
Contributor

angle943 commented Mar 4, 2021

Make the AccountManager rely on thenewboston-js repo fully

@angle943
Copy link
Contributor Author

angle943 commented Mar 4, 2021

please get permission from me to work on it before you start

@tomijaga
Copy link

tomijaga commented Mar 4, 2021

@angle943 Can I work on this

@angle943
Copy link
Contributor Author

angle943 commented Mar 4, 2021

i don't believe the sdk library is ready yet. talk to @zinoadidi about the progress

@tomijaga
Copy link

This would be useful for this task.
https://docs.google.com/document/d/1FaPq2stWP0lMtHATNIfLA6ryMd0PtUYdcnrvZbUk7FI/edit
Its a documentation of the similar functions and their locations between Account manager and thenewboston-js

@tomijaga
Copy link

Hey @angle943, is the list of functions in the document above okay for the account manager or is there anything u would like to add to this list.

@angle943
Copy link
Contributor Author

@tomijaga to be honest I currently don't have the bandwidth to look over the document in detail. But we can start going as is. Are you working in tandem with @zinoadidi about these issues?

@zinoadidi
Copy link

@angle943 I have already a roadmap item for the switch, I will handle the process from my end with @tomijaga.

Also we are working together to make missing features already, once they are complete, I will kick off milestones for the conversion process

@zinoadidi
Copy link

zinoadidi commented Mar 30, 2021

@angle943 since development for this is starting soon, can you make a dedicated branch for us so @tomijaga can make all PR to. and when specific milestones will be complete, we can just sync the branches and merge a group of completed tasks to development

@angle943
Copy link
Contributor Author

@zinoadidi hmm perhaps it might be better to sync up offline later, but question for you, how soon do you think you can incorporate the AccountManager with the SDK? The reason why I ask is that we are soon having a switch to beta, which might end up changing a lot of our BE end points and results

@zinoadidi
Copy link

zinoadidi commented Mar 31, 2021

@angle943 I have also considered this as well and the proposal is we are going to sync up the SDK development with beta updates as they come; I am working to secure one or two contributors who will be dedicated to this activity.

Concerning Account Manager, there is approximately 1 task pending test from the list of missing functionalities we started to work on a couple of days ago.
That means we can already start switching usage by Friday / weekend (@tomijaga is dedicated to this task)

According to our roadmap; we plan to keep the account manager in sync with SDK no matter what :) and we are ensuring this happens by such kinds of tasks thenewboston-blockchain/thenewboston-js#88

@angle943
Copy link
Contributor Author

sounds good, here is the migration branch: https://github.com/thenewboston-developers/Account-Manager/tree/javascript-sdk-migration

@zinoadidi
Copy link

@angle943 All changes are done and ready for review

@TouchstoneTheDev
Copy link

Is this closed or bounty open ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants