Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website text size got small sitewide #1722

Closed
kristykjlee opened this issue Apr 16, 2021 · 4 comments · Fixed by thenewboston-blockchain/ui-js#18
Closed

Website text size got small sitewide #1722

kristykjlee opened this issue Apr 16, 2021 · 4 comments · Fixed by thenewboston-blockchain/ui-js#18
Assignees
Projects

Comments

@kristykjlee
Copy link

Bug Description
All the body text size in our website looks small, can we revert it back to what it use to be?

Steps to Reproduce
Steps to reproduce the behavior:
thenewboston.com

Expected behavior
Body font was 16px and 14px in leaderboard

Actual behavior
Everything looks either 14px or 12px.

OS and Browser
chrome

@jamessspanggg
Copy link
Contributor

@thesanjeevsharma @angle943 did some investigation here 😟:

When inspecting through chrome, the :root style seems to not match with the global _font.scss values, since mostly our fonts utilises --font-size-regular, it became 14px instead of 16px:
Screen Shot 2021-04-17 at 6 00 19 PM

Screen Shot 2021-04-17 at 5 44 26 PM

@jamessspanggg
Copy link
Contributor

ah realised what was the issue, it was because @thenewboston/ui package contains a font.css file which also sets the :root css for fonts. I believe what happen was the _font.scss file was loaded and parsed first before the font.css of @thenewboston/ui, which caused the latter to have a higher specificity 😧

Screen Shot 2021-04-17 at 8 02 37 PM

@jamessspanggg
Copy link
Contributor

Created a temporary solution which is to standardise the :root css in the @thenewboston/ui repo. However, this might not be the best solution as when one side changes, we will need to standardise with the other to prevent conflict.

A better solution may be just to make the @thenewboston/ui css local to itself.

@jamessspanggg jamessspanggg added this to In progress in FE-Team Apr 18, 2021
@jamessspanggg
Copy link
Contributor

@angle943 can you take a look at this issue? it may affect the App wide UI update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants