New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API method to get path to latest available blockchain state #252
Comments
@andbortnik I rename |
@dmugtasimov Please review #291 What do we do if the requested node is unregistered in the blockchain? In the PR |
@andbortnik let's serve as usual. Just put a HIGH priority TODO about it. Because normally if a node unregisters itself it should also become offline and also even if it does not since it is unregistered other nodes should not consider it as available and therefore do not make API requests to it. |
@andbortnik I added some comments (maybe I will have more later). The main issue is that representation logic was put into business logic. Please, address the comments. |
@andbortnik also if you wish you may submit changes in smaller PRs. I do it sometimes myself: just abandon the entire large PR and make many more smaller PRs untill I cover everything I had in the large PR originally. This up to you, just a suggestion. |
@dmugtasimov Fixed |
@andbortnik is this PR #329 ready for merge? |
@andbortnik #329 merged, thank you |
@andbortnik please, address the comment for #350 |
@andbortnik rebase required: #351 |
@andbortnik #350 merged, thank you |
Fixup: #366 |
@andbortnik Thank you #351 is merged |
@andbortnik thank you, #364 merged |
@andbortnik is there anything left to do in this task? |
Nothing. I'll close the task |
TODO:
thenewboston_node.business_logic.blockchain.file_blockchain.get_blockchain_state_filename_meta
block_number
blockchain
applicationResponse example:
Use this code for pagination:
The text was updated successfully, but these errors were encountered: