Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving opened cadnano file will overwrite file #15

Closed
Sebastian-Jung opened this issue Nov 3, 2021 · 3 comments
Closed

Saving opened cadnano file will overwrite file #15

Sebastian-Jung opened this issue Nov 3, 2021 · 3 comments
Labels
bug Something isn't working enhancement New feature or request solved in dev A fix is avalaible in dev and will be included in the next release

Comments

@Sebastian-Jung
Copy link

Sebastian-Jung commented Nov 3, 2021

This might not be a bug but it can be really bad for new users.
How to reproduce:

  • Open ensnano
  • Load a .json file created by cadnano
  • Click Ctrl+S or Save the file
  • Expected: Ask for new location/filename since the file wasn't saved in a .ens format before
  • What actually happens: The location and name of the cadnano file is taken as the path to the file. Saving the design will overwrite the .json cadnano file. This will destroy the file and one cannot load the file back into cadnano since the formats are not compatible, which might be a big problem for some users.
@thenlevy thenlevy added bug Something isn't working enhancement New feature or request labels Nov 3, 2021
@thenlevy
Copy link
Owner

thenlevy commented Nov 3, 2021

That's the intended behavior but I agree that it should be changed. I did not realize that user could lose their cadnano file because of it.

@Sebastian-Jung
Copy link
Author

Maybe an explicit Import function in addition to Open might be useful, this would also allow importing multiple files (from cadnano, scadnano) in one ensnano session.

@thenlevy
Copy link
Owner

thenlevy commented Nov 4, 2021

I've pushed a path to the dev branch that fixes this problem. What it does is that a new file name is asked when saving if the current file name does not have the .ens extension.

Since this is quite critical we will soon release binaries that include this patch.

Regarding the import of multiple designs into one single ENSnano session, I agree that this can be useful, I will create a specific issue for that: #17

@thenlevy thenlevy added the solved in dev A fix is avalaible in dev and will be included in the next release label Nov 4, 2021
This was referenced Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request solved in dev A fix is avalaible in dev and will be included in the next release
Projects
None yet
Development

No branches or pull requests

2 participants