Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some improvements #3

Merged
merged 3 commits into from Dec 22, 2017
Merged

Added some improvements #3

merged 3 commits into from Dec 22, 2017

Conversation

long1eu
Copy link
Contributor

@long1eu long1eu commented Dec 22, 2017

Hi!

I've restructured your library according to https://www.dartlang.org/guides/libraries/create-library-packages and added a new type of image source. I've you this library for some time and i've bee very pleased with it. .

Copy link
Owner

@theobouwman theobouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theobouwman theobouwman merged commit 54c2944 into theobouwman:master Dec 22, 2017
@long1eu
Copy link
Contributor Author

long1eu commented Dec 22, 2017

Thanks mate! Let me know you publish it.

@theobouwman
Copy link
Owner

Published the package: https://pub.dartlang.org/packages/image_carousel

@long1eu
Copy link
Contributor Author

long1eu commented Dec 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants