Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Event Manager #321

Closed
ghost opened this issue May 26, 2018 · 8 comments
Closed

Event Manager #321

ghost opened this issue May 26, 2018 · 8 comments

Comments

@ghost
Copy link

ghost commented May 26, 2018

Please someone important review this section, it surely needs some work. For example, at many places the code seemed complete but gave an error when i ran it, because it was incomplete. If its not complete on purpose then atleast state that, and at some places the code is formated as simple text.

@KevinMulhern
Copy link
Member

Hey @sarthak-v, can you be a bit more specific with whats broken please?

Can you provide some example of which parts you ran and got an error and what the error was?

@ghost
Copy link
Author

ghost commented May 27, 2018

@ghost
Copy link
Author

ghost commented May 27, 2018

screenshot from 2018-05-27 08-02-08
code in this section (ERB) is not working as stated.

@KevinMulhern
Copy link
Member

Thanks @sarthak-v, the code high lighting should be easy enough to fix. I'll create a separate issue for that.

As for the erb section, can you tell use the specific error you were getting with it? that will help us narrow down the debugging.

@ghost
Copy link
Author

ghost commented May 27, 2018

The code is wrongly replacing the legislators in the form. Its showing that rescue text even when the info is available.

@ghost ghost closed this as completed May 29, 2018
@KevinMulhern
Copy link
Member

Hey @sarthak-v, did that PR you made address the problems here? what about the issue with erb code snippet? 😄

@ghost
Copy link
Author

ghost commented May 29, 2018

i will update all the incorrect codes(if there are, other than erb code) by today or tmrw

@ghost ghost reopened this May 29, 2018
@ghost
Copy link
Author

ghost commented May 30, 2018

everything's working fine

@ghost ghost closed this as completed May 30, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant