Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is lighthouse disabled in script mode? #187

Open
jampow opened this issue May 5, 2020 · 1 comment
Open

Why is lighthouse disabled in script mode? #187

jampow opened this issue May 5, 2020 · 1 comment

Comments

@jampow
Copy link

jampow commented May 5, 2020

Hi, is there a reason to disable lighthouse option in script mode?

I have some pages in ABTest and need to set a cookie to test the right variation, but I would like to see the lighthouse report too.

if audit.page is not None:
payload["url"] = audit.page.url
payload["lighthouse"] = 1
payload["k"] = audit.page.project.wpt_api_key
wpt_instance_url = audit.page.project.wpt_instance_url
elif audit.script is not None:
payload["script"] = audit.script.script
payload["k"] = audit.script.project.wpt_api_key
wpt_instance_url = audit.script.project.wpt_instance_url

@fargito
Copy link
Contributor

fargito commented May 11, 2020

Hello @jampow, I think that lighthouse scores can only be computed for single pages and not for scripts, but I may be mistaken. What happens if you enable the lighthouse option on scripts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants