You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the trailing comma lint rule causes issues when trying to import this into coffeescript and using an older node version (6.11) eslint/eslint#7749
This unfortunately prevents me from using the module or submitting a PR to fix since removing the comma on GoogleSpreadsheet.js:39 breaks the linting rule.
Any chance you would reevaluate this rule?
The text was updated successfully, but these errors were encountered:
Well, I wouldn't consider getting rid of trailing commas in general, because I think it's just more consistent and keeps diffs smaller.
BUT it appears the issue may only have to do with trailing commas on multiline function params, which is pretty rare, and kind of weird anyway. Ive pushed up a branch, so you can test it before I commit the change and bump the version.
Try replacing the dependency in your package.json file with theoephraim/node-google-spreadsheet#no-dangling-comma-functions and let me know if that fixes it!
the trailing comma lint rule causes issues when trying to import this into coffeescript and using an older node version (6.11)
eslint/eslint#7749
This unfortunately prevents me from using the module or submitting a PR to fix since removing the comma on GoogleSpreadsheet.js:39 breaks the linting rule.
Any chance you would reevaluate this rule?
The text was updated successfully, but these errors were encountered: