Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trialing comma breaks importing into coffeescript #297

Closed
ThrowsException opened this issue Feb 13, 2020 · 3 comments
Closed

Trialing comma breaks importing into coffeescript #297

ThrowsException opened this issue Feb 13, 2020 · 3 comments

Comments

@ThrowsException
Copy link

the trailing comma lint rule causes issues when trying to import this into coffeescript and using an older node version (6.11)
eslint/eslint#7749

This unfortunately prevents me from using the module or submitting a PR to fix since removing the comma on GoogleSpreadsheet.js:39 breaks the linting rule.

Any chance you would reevaluate this rule?

@theoephraim
Copy link
Owner

Well, I wouldn't consider getting rid of trailing commas in general, because I think it's just more consistent and keeps diffs smaller.

BUT it appears the issue may only have to do with trailing commas on multiline function params, which is pretty rare, and kind of weird anyway. Ive pushed up a branch, so you can test it before I commit the change and bump the version.

Try replacing the dependency in your package.json file with theoephraim/node-google-spreadsheet#no-dangling-comma-functions and let me know if that fixes it!

@ThrowsException
Copy link
Author

Yup that fixes the issue.

@theoephraim
Copy link
Owner

just published the update to npm.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants