Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added charsequence overloaded method for uri parsing #16

Merged
merged 1 commit into from
Jun 23, 2013
Merged

Added charsequence overloaded method for uri parsing #16

merged 1 commit into from
Jun 23, 2013

Conversation

sksamuel
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 11b6daf on sksamuel:master into 1b59c73 on theon:master.

@theon
Copy link
Contributor

theon commented Jun 23, 2013

I'm tempted to just remove the method that takes a String argument and just have the CharSequence one. What do you think?

@sksamuel
Copy link
Contributor Author

Would do the same thing, and wouldn't break backwards compatibility since
string implements charseq

On 23 June 2013 16:27, Ian Forsey notifications@github.com wrote:

I'm tempted to just remove the method that takes a String argument and
just have the CharSequence one. What do you think?


Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-19875643
.

theon added a commit that referenced this pull request Jun 23, 2013
Added charsequence overloaded method for uri parsing
@theon theon merged commit f4b8426 into NET-A-PORTER:master Jun 23, 2013
@theon
Copy link
Contributor

theon commented Jun 23, 2013

This should be available in 0.3.6-SNAPSHOT now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants