[FEATURE] Configurable peer status visibility #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GenericStudent
force-pushed
the
feature/peers-status-visibility
branch
from
43b3376
to
eda8cf5
Compare
|
@theonemcdonald is there a newer process for developing / pull requests / issues? I see the issues have been removed from this repo and and curious if I've skipped a process regarding this pr as I've got some more things I'd like to develop further. Edit: also congrats on your employment change! |
GenericStudent
force-pushed
the
feature/peers-status-visibility
branch
from
0601e37
to
46f0989
Compare
|
@theonemcdonald, I've rebased to bring this PR up-to-date with main. Is there any comments / objections to this PR? |
|
Has the development ceased on the project, or happening elsewhere? Can you take a look at the 2 PRs that @GenericStudent has sent? Both seems pretty useful. |
|
No it hasn't ceased. I've been working on some pretty significant changes,
that incrementally pushing code just isn't feasible especially when people
are git cloning code onto their firewalls. There will be more traction
after we release 21.09 in the coming weeks, at that point I'll poke more
into these PRs and see if they can be accepted for an interim release while
I continue work on those significant changes that I mentioned above.
On Sun, Aug 29, 2021 at 3:25 AM Jeffrey Jose ***@***.***> wrote:
Has the development ceased on the project, or happening elsewhere? Can you
take a look at the 2 PRs that @GenericStudent
<https://github.com/GenericStudent> has sent? Both seems pretty useful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#144 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXVKV4Z62KH4F342WHNZY3T7HOFRANCNFSM5APNNOTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*R. Christian McDonald *
M: (616) 856-9291
E: ***@***.***
|
|
That's fair, and thanks for being thoughtful to the folks who have been running this on production. In the spirit of open-source, might I suggest you continue developing this package in the open, perhaps in a different branch and merge back to |
…, based on config
…he checkbox is ot checked
GenericStudent
force-pushed
the
feature/peers-status-visibility
branch
from
d770f4e
to
4e69a59
Compare
…on-flickering css hiding of peers on page load if user still wants it
rcmcdonald91
added a commit
that referenced
this pull request
Sep 27, 2021
* [FEATURE] Configurable peer status visibility (#144) * Rebased with upstream/main to resolve conflicts * Status page now loads default peer visability from settings * Store the hide_peers setting on POST * Added GUI function to determine if the peers should be visible or not, based on config * Added hide_peers config upgrade migration * Corrected my bad assertion that POST param will carry 'no' value if the checkbox is ot checked * Moved help text to be inline with other translatable help texts * Missed gettext on settings * Added CSS logic controlled by our default setting state, allows the non-flickering css hiding of peers on page load if user still wants it Co-authored-by: R. Christian McDonald <rcmcdonald91@gmail.com> * Cleanup peer visibility feature Co-authored-by: Adam Cooper <13488006+GenericStudent@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to configure the default visibility for all Peers on the Status page.
Personally I like to see all Peers on status page load as I don't have too many. It defaults to true (consistent with pre PR behaviour).