Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX Resolves treegrid flickering #148

Merged

Conversation

GenericStudent
Copy link
Contributor

Inline with my previous PR of using CSS to display:none the items we didn't want to see on page load (tunnels list always and status page only if use has unchecked hide peers checkbox).

I still feel leacing it to the JS to hide the rows leads to poor UX with flickering

…-parent- child trs as they are visible on page load until jQuery plugin collapses them, causing a noticable flicker
@rcmcdonald91 rcmcdonald91 merged commit 5177809 into rcmcdonald91:main Sep 28, 2021
@rcmcdonald91
Copy link
Owner

It took me long enough to realize what flickering you were referring too...the brief instance where the table is completely visible before the tree is initialized by JS. lol Yea, this seems like a reasonable solution.

@GenericStudent GenericStudent deleted the bugfix/tablegrid-flicker branch September 28, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants