Handle errors from strtol

Author: theory

Changes

@@ -1,8 +1,9 @@
 Revision history for PostgreSQL extension semver.
 
 0.31.2
-      - Fix an overflow check to properly compare the max size of INT32
-        rather than INT. Thanks to Felix Lechner for the report (#58).
+      - Add an overflow check and properly compare the max size of INT32
+        rather than INT. Thanks to Felix Lechner for the report and Tom Lane
+        for the C lesson (#58).
 
 0.31.1  2021-04-27T00:10:07Z
       - Updated the C code to pass the correct number of arguments to

src/semver.c

@@ -123,6 +123,7 @@ semver* parse_semver(char* str, bool lax, bool throw, bool* bad) {
                 atchar++;
                 curpart++;
             } else {  // OK, it should be a version part number then
+                errno = 0;
                 num = strtol(ptr, &endptr, 10);
                 // N.B. According to strtol(3), a valid number may be preceded
                 // by a single +/-, so a value like 0.1-1 will end up being
@@ -142,7 +143,7 @@ semver* parse_semver(char* str, bool lax, bool throw, bool* bad) {
                         elog(ERROR, "bad semver value '%s': expected number/separator at char %d", str, atchar);
                     }
                 }
-                if (num > INT32_MAX) {  // Too big
+                if (errno != 0 || num > INT32_MAX) { // Invalid or too big
                     *bad = true;
                     if (!throw) break;
                     elog(ERROR, "bad semver value '%s': version number exceeds 31-bit range", str);