Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards more sensible svnnotify output (--diff-copy-from, --copy-info) #3

Open
skoehler opened this issue May 20, 2012 · 1 comment

Comments

@skoehler
Copy link

Consider the email svnnotify generated, when you do the following:
svn cp test1.txt test2.txt
svn commit

You will get a diff as if test2.txt was a new file. Something like this:
Copied: trunk/test2.txt (from rev 6, trunk/test1.txt)

--- trunk/test2.txt (rev 0)
+++ trunk/test2.txt 2012-05-20 13:20:40 UTC (rev 7)
@@ -0,0 +1 @@
+test2

IMHO, that is too verbose. I don't want to review the whole view. I only want to review the changes that have been made. (Imagine test1.txt and test2.txt to be Source code, not ordinary text files) Obviously I can use svnlook diff with --diff-copy-from, but then the output of svnlook diff will be empty. Now the tragic thing is, that in the commit email svnnotify would generate, I would not be aware that test2.txt has been added (since the output of svnlook changed lists it) but I would not be able to see that it is a copy of test1.txt, since svnlook diff --diff-copy-from skips the file completely.

One solution is to change svnlook diff --diff-copy-from in a way such that it does not simple omit any information about test2.txt. I'm talking about that with the subversion developers, but to be honest that idea will probably not be very welcome.

Another way of dealing with this would be to enhance svnnotify with support for svnlook changed --copy-info. The output is as follows:
A + trunk/test2.txt
(from trunk/test1.txt:r6)

Using --copy-info in combination with --diff-copy-from would be an ideal combination. However, svnnotify would have to enhanced to support and parse the output of --copy-info.

@theory
Copy link
Owner

theory commented May 20, 2012

If this is something you would like to work on and submit a pull request, that would be great. I don't really have the tuits right now, especially since i no longer use SVN::Notify myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants