Fixed failing tests #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to address changes in Text::Diff v1.44
|
Yes please! +++++ |
|
yes please too ++++ |
|
It currently breaks our build. Can we have that merged? Thanks! |
|
I'm working on a fix that's backwards compatible by adding the missing newlines so that that message never shows up. But it's complicated a bit by this issue, I think. |
|
That should do it. Turns out that this was not an issue at all. Thanks for the catch, folks! I'll push out a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to address changes in Text::Diff v1.44