Autolink support without <...>

[colinodell]

See thephpleague/commonmark#308

[tankerkiller125]

Have a look at OSSchools/commonmark-ext to see how I've done this. You can pretty much copy it although you'll need to remove the URLMeta stuff (automatic titling of links based on webpage title)

I should also mention that there is code for strike though support in that repo as well for #6

[markhalliwell]

Their approach of using an inline parser seems... really expensive. It's literally matching ever alphanumeric character and then doing a regexp check on... everything.

I think it would make more sense to implement a DocumentProcessorInterface extension after all is said and done to do a global match and replace for any remaining stragglers that haven't been caught.

[glensc]

@tankerkiller125 OSSchools/commonmark-ext seems to do too much and adding unwanted dependencies:

• laravel/framework
• mpratt/embera

I don't want markdown rendering library have code to fetch remotes via curl. violates single responsibility principle.

[glensc]

@colinodell maybe you want(can, please!?:) to create single purpose supported version under thephpleague to handle this kind of problem, like you did for thephpleague/commonmark-ext-smartpunct and thephpleague/commonmark-ext-inlines-only

i have this in checklist to transition to commonmark:

• Replace markdown implementation with thephpleague/commonmark eventum/eventum#501 (comment)

[colinodell]

Yep I will work on creating this. I'll either be following @MarkCarver's suggestion or thephpleague/commonmark#345 if that seems to be viable

[glensc]

I think the big end goal would be to have GFM (GitHub Flavored Markdown / GitLab Flavored Markdown) enable-able with single extension:

• https://github.github.com/gfm/
• https://docs.gitlab.com/ee/user/markdown.html

currently picking features one by one while just want what people are accustomed for, and that's GFM!

[tankerkiller125]

@glensc That package was designed specifically for the core project they were built, hence the Laravel requirements and other requirements. The actual code for the auto-linking however did not require those extra dependencies.

[colinodell]

This has been implemented via https://github.com/thephpleague/commonmark-ext-autolink/blob/v0.1.0/src/AutolinkExtension.php. We'll pull it into here as a dependency.