Consider making the renderers non-final

[freekmurze]

Our package extends some of the renderers of this package. Could you consider making your classes non-final?

[colinodell]

The renderers are marked final because they only implement the public interface and nothing else. Hypothetically speaking, if we did allow sub-classes like in 0.x, the only thing you could do with them is to call that method on the parent, but that can be done without subclassing it! So, instead of extending the class in order to call that one method, why not simply instantiate an instance of it instead? For example:

<?php
 
 namespace Spatie\CommonMarkHighlighter;
 
 use League\CommonMark\ElementRendererInterface;
 use League\CommonMark\Block\Element\AbstractBlock;
+use League\CommonMark\Block\Renderer\BlockRendererInterface;
 use League\CommonMark\Block\Renderer\IndentedCodeRenderer as BaseIndentedCodeRenderer;
 
-class IndentedCodeRenderer extends BaseIndentedCodeRenderer
+class IndentedCodeRenderer implements BlockRendererInterface
 {
     /** @var \Spatie\CommonMarkHighlighter\CodeBlockHighlighter */
     protected $highlighter;
 
+    /** @var BaseIndentedCodeRenderer */
+    protected $baseRenderer;
 
     public function __construct(array $autodetectLanguages = [])
     {
         $this->highlighter = new CodeBlockHighlighter($autodetectLanguages);
+        $this->baseRenderer = new BaseIndentedCodeRenderer();
     }
 
     public function render(AbstractBlock $block, ElementRendererInterface $htmlRenderer, $inTightList = false)
     {
-        $element = parent::render($block, $htmlRenderer, $inTightList);
+        $element = $this->baseRenderer->renderer($block, $htmlRenderer, $inTightList);
 
         $element->setContents(
             $this->highlighter->highlight($element->getContents())
         );
 
         return $element;
     }
 }

(This code is untested but it should work)

[freekmurze]

Thanks 👍