Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 Support #759

Closed
yochanan-gurovich opened this issue Nov 30, 2021 · 1 comment · Fixed by #762
Closed

PHP 8.1 Support #759

yochanan-gurovich opened this issue Nov 30, 2021 · 1 comment · Fixed by #762
Labels
fixed Fix has been implemented
Milestone
v2.1

Comments

@yochanan-gurovich
Copy link

yochanan-gurovich commented Nov 30, 2021 •
edited

Version(s) affected

2.0.2

Description

Deprecated: Return type of League\CommonMark\Util\ArrayCollection::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in ../vendor/league/commonmark/src/Util/ArrayCollection.php on line 110

How to reproduce

Install php 8.1, version 2.0.2 of this package and convert this to HTML:

```
code inside 
```

Possible solution

No response

Additional context

No response

Did this project help you today? Did it make you happy in any way?

No response
@colinodell colinodell linked a pull request Dec 5, 2021 that will close this issue
PHP 8.1 deprecated warning #762
Merged
@colinodell
Copy link
Member

Fixed via #762

@colinodell colinodell added implemented Change has been implemented fixed Fix has been implemented and removed implemented Change has been implemented labels Dec 5, 2021
@colinodell colinodell added this to the v2.1 milestone Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Fix has been implemented
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

PHP 8.1 deprecated warning ElGigi/commonmark
2 participants
@colinodell @yochanan-gurovich