Unwanted additional line at end of CSV file

[garethellis36]

I'm trying to create a new CSV file and write it to disk so that it can be emailed. This may not be an issue with the package but may be an issue with the way I am doing things.

Code:

    //create empty file to store CSV data (is there a better way of doing this?)
$handle = fopen($filepath, "w");
fwrite($handle, "");

    //create new writer instance
$csv = League\Csv\Writer::createFromPath(new SplFileObject($filepath));

    //insert data from array
$csv->insertAll($csv_data);

The resulting CSV has all the data in it as expected but there is an additional line with no entry on it.

This is a problem because the resulting CSV has to be uploaded into an Oracle-based system and it does not like empty lines in CSV files.

[nyamsprod]

Ok as per the documentation there are several ways to instantiate the object I think you've just combined many of them. The problem may be related to that. I would suggest, simplify your code like below:

$filepath = '/path/to/my/csv/file.csv';
$csv = League\Csv\Writer::createFromPath($filepath, 'w');
$csv->insertAll($csv_data);

Nothing more... it will work and the empty line should disappear. You do not need to use fopen first. by using the w open mode the library will try to open or create the file if it does not succeed a RuntimeException will be thrown.

[garethellis36]

Thanks for your response. I was trying something similar but the missing piece was the "w" in the second argument to create the file.

Anyway, it's still putting an empty line at the end of the CSV file.

Code is now:

$csv = League\Csv\Writer::createFromPath($filepath, "w");
$csv->insertAll($csv_data);

[nyamsprod]

The end line is put because of SplFileObject::fputcsv as per documentation:

fputcsv() formats a line (passed as a fields array) as CSV and write it (terminated by a newline) to the specified file handle.

[garethellis36]

Is it worth doing a PR to have an option which doesn't include the newline?

[nyamsprod]

No need to PR this, there's a quick workaround for that:

function outputWithoutEndingEOL(League\Csv\AbstractCSV $csv)
{
    return  rtrim($csv->newReader());
}