Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move exceptions into their own folder #65

Closed
philsturgeon opened this issue Jul 15, 2014 · 0 comments · Fixed by #77
Closed

Move exceptions into their own folder #65

philsturgeon opened this issue Jul 15, 2014 · 0 comments · Fixed by #77
Milestone
v2.0.0

Comments

@philsturgeon
Copy link
Member

Copied from fork repo written by @scottrobertson.

While we are switching to V2, i would like to clean up how we store Exceptions.

Currently it is src/League/FactoryMuffin/NoDefinedFactoryException.php

I feel like it should be more like src/League/FactoryMuffin/Exception/NoDefinedFactory.php
@GrahamCampbell GrahamCampbell mentioned this issue Jul 16, 2014
Merged
@scottrobertson scottrobertson added this to the v2.0RC1 milestone Jul 17, 2014
@GrahamCampbell GrahamCampbell modified the milestones: v2.0.0, v2.0.0-RC1 Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Refactored Exceptions
3 participants
@philsturgeon @scottrobertson @GrahamCampbell