Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative fix option for ACL error with GoogleCloud adapter on copy #1634

Closed
wants to merge 1 commit into from
Closed

Alternative fix option for ACL error with GoogleCloud adapter on copy #1634

wants to merge 1 commit into from

Conversation

silverbackdan
Copy link

Alternative to #1629
Fixes #1633

@silverbackdan
Copy link
Author

silverbackdan commented Jan 26, 2023 •
edited

Alternatively we could check $this->visibilityHander instanceof UniformBucketLevelAccessVisibility and use the default visibility configured.

There are a number of ways to resolve this issue. Happy to discuss which is best.

I think for no ACL the recommended approach was new GoogleCloudStorageAdapter(bucket: $bucket, visibilityHandler: new UniformBucketLevelAccessVisibility())

@silverbackdan silverbackdan mentioned this pull request Jan 26, 2023
Merged
@silverbackdan
Copy link
Author

Apologies, I hadn't seen where the file was changed, the other fix looks better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google ACL called causes error during copying
1 participant
@silverbackdan