Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out paginators #480

Closed
matthewtrask opened this issue May 2, 2019 · 6 comments
Closed

Pull out paginators #480

matthewtrask opened this issue May 2, 2019 · 6 comments
Assignees
Labels

Comments

@matthewtrask
Copy link
Contributor

Fractal ships with the following paginators:

  • Doctrine
  • Phlacon
  • Laravel
  • PagerFanta
  • Zend

I think we should make a basic paginator class, and move these 5 to separate repositories that can be suggested via Composer.

Thoughts?

@johannesschobel
Copy link
Contributor

In general, i think, this is a good idea.. However, this would make the release-process of a new fractal version way more complicated, because you need to keep those packages in-sync..

@matthewtrask
Copy link
Contributor Author

@johannesschobel I agree. But since the paginators (probably) won't change much, it might not be terrible to maintain them. Or even find people who are willing to help us keep up.

@johannesschobel
Copy link
Contributor

I definitely agree, that it would add a certain level of flexibility..
All the best

@KorvinSzanto
Copy link
Contributor

I agree these are best separated out, this was brought up as part of #474.

this would make the release-process of a new fractal version way more complicated, because you need to keep those packages in-sync

One thing to remember with releases is that we don't necessarily have to release a new version of the paginators / serializers every time we release a core version. There are option, for example we might want to keep just the major version numbers in sync.

@matthewtrask matthewtrask self-assigned this Jun 29, 2019
@KorvinSzanto
Copy link
Contributor

KorvinSzanto commented Jun 30, 2019

I've split out the paginators:

Just need to get an array paginator and an iterator paginator setup and packagist sorted and we should be good.

@matthewtrask
Copy link
Contributor Author

Im going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants