Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra '/' on getUrl() #119

Closed
hiendv opened this issue Jan 17, 2016 · 1 comment
Closed

Extra '/' on getUrl() #119

hiendv opened this issue Jan 17, 2016 · 1 comment

Comments

@hiendv
Copy link

hiendv commented Jan 17, 2016

In my opion, prepending / to the path is unnecessary which sometimes miscorrects my image's source or makes it //. baseUrl alone is enough, I think.
https://github.com/thephpleague/glide/blob/1.0.0/src/Urls/UrlBuilder.php#L76

@drhino
Copy link

drhino commented Jun 4, 2017

As far as I know, you better have an extra forward slash in stead of none at all.
Correct me if I'm wrong.

You can still use:
$your_url = str_replace('//', '/', $your_url);
in your application to filter it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants