Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrantInterface Exception always false #65

Closed
kevindierkx opened this issue Mar 11, 2014 · 1 comment
Closed

GrantInterface Exception always false #65

kevindierkx opened this issue Mar 11, 2014 · 1 comment

Comments

@kevindierkx
Copy link
Contributor

The elseif statement checking if the $grant is an instance of Grant\GrantInterface always returns false since Grant\GrantInterface isn't even available.

Im talking about the following snippet:

} elseif ( ! $grant instanceof Grant\GrantInterface) {
    throw new \InvalidArgumentException($grant.' is not an instance of \OAuth2\Client\Grant\GrantInterface');
}

Replacing Grant\GrantInterface with \OAuth2\Client\Grant\GrantInterface resolves the issue.
Is this correct or am I doing something wrong here?

@TomHAnderson
Copy link
Contributor

Yes: what you were doing wrong was reporting and not PRing

Fixed with #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants