Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme example faulty #81

Closed
assertchris opened this issue Apr 29, 2014 · 3 comments
Closed

Readme example faulty #81

assertchris opened this issue Apr 29, 2014 · 3 comments

Comments

@assertchris
Copy link

There's an undefined $refreshToken. Did you mean $token->refreshToken?

@TomHAnderson
Copy link
Contributor

No. The Token/AccessToken object is not an access token. So to preserve the refreshToken returned at the same time and stored in the Token/AccessToken object in session as an object you would be correct but I do not promote storing objects in the session so I presume you have stored the refreshToken somewhere else hence my promotion and use of the singular variable instead of an object property.

@philsturgeon
Copy link
Member

@TomHAnderson that answer unfortunately misunderstands what @chrispitt was asking. There was a random variable in the README that had not been instantiated and had no connection to anything. That is gone now in my reshuffle of the README and its sample code.

@assertchris
Copy link
Author

Spot on, Mr Sturgeon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants