Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Symfony 3.0 #65

Closed
mkrauser opened this issue Dec 1, 2015 · 9 comments
Closed

Compatibility with Symfony 3.0 #65

mkrauser opened this issue Dec 1, 2015 · 9 comments

Comments

@mkrauser
Copy link

mkrauser commented Dec 1, 2015

currently omnipay requires

"symfony/http-foundation": "~2.1"

which makes it currently unusable in Symfony 3.0 projects.
Symfony 3.0 was released yesterday.

Thank you for looking into this.

@mkrauser
Copy link
Author

mkrauser commented Dec 4, 2015

Also, guzzle 3.9, which is also required by omnipay-common required the symfony event-dispatcher 2.x which results in the same problem

@frederikbosch
Copy link

And I would recommend to change the current dependency into "symfony/http-foundation": "~2.7.0". With http foundation 2.8.0 you receive symfony/polyfill-php54 for free and as PHP 5.6 user I do not like to see such a dependency entering my project suite.

@barryvdh
Copy link
Member

See #67

@wimpog
Copy link

wimpog commented Jan 30, 2017

Hi Barry,
Could you please tell me the overall state of OmniPay version 3.
I see that you've been replacing Guzzle with PHP-HTTP.
Is there a reason you chose not to use Guzzle 6?
What is left to be done in omnipay-common?
What's the difference between branch 3.0 and 3.0-simple? Do they have different purposes? I see one uses Guzzle, and the other one does not.
I see you require PHP 5.6, or 7: "php": "^5.6|^7". I use php 5.5.29, would it be ok with 5.5?
Thanks,

@barryvdh
Copy link
Member

Php 5.5 is not supported anymore.
Guzzle will be de default adapter for Php http, just not tied to it.
Overall state is that this should be able to release not to far from now, while 3.0 branch can be pushed back as 4.0

@wimpog
Copy link

wimpog commented Jan 30, 2017

What's the difference between branch 3.0 and 3.0-simple? Do they have different purposes? I see one uses Guzzle, and the other one does not.

@barryvdh
Copy link
Member

3.0 is simpler. Both use psr7 and both can support guzzle.

@barryvdh
Copy link
Member

Sorry, 3.0-simple is simpler. It's an intermediate version for easier upgrading.

@wimpog
Copy link

wimpog commented Jan 30, 2017

Barry,
Will version 3 continue with Guzzle or PHP-HTTP?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants