payeezy updated to supported JSON api

[davidbankes]

The PayEezy API does not support the text/html response type. This package depends on that response type. It has worked up to this point. It broke recently in the test mode. The response was URL encoded, but it changed to being HTML encoded and the URL encoded on top of that.

This causes the response data array to have things like [..., 'amp;transaction_approved' => 1, ...] instead of the expected [..., 'transaction_approved' => 1, ...]

I emailed Chris Lord (Payeezy Support support.payeezy@firstdata.com). After some back and forth he said,

I had a discussion with our level 2 team and application development teams regarding this matter. They advised that the URL encoded content type is not technically an approved message/encoding format. The supported formats are SOAP, XML, and JSON.

This pull request updates the PayEezy gateway to request the JSON response format. With these changed, the package works in test mode again. Until moving to a supported response format, the production mode cannot be trusted, as it could break like the test mode any time.

[davidbankes]

The one failing check is for php 5.3. It looks like the CI pipeline fails to create the environment, not that the code is actually failing to pass the tests. Notice that the current master branch is failing.

The other checks all passed.

Should the pipeline be modified at this point? Also, there's no pipeline for php 7.1 or 7.2.

[davidbankes]

@barryvdh

This has been setting here for a few days. Is there an active maintainer for this omnipay driver? Are you able to review this MR and let me know if any changes are required?

[raczMedia]

is this still getting fixed?

[judgej]

The failures here are only for PHP 5.3. I think is it safe enough to drop PHP 5.3 support from this package now (in this PR), then this PR may get some visibility. PRs with failing tests seldom get looked at. That;s just the for practical purposes - people are very busy.

[davidbankes]

Fair suggestion. I'll try to get 5.3 pulled out over the holidays.

[davidbankes]

Thanks @tszulc ... this pull request is passing now. Maybe someone will get this fix in properly.