Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PxPay request returnUrl encoding. #57

Open
dm1tr1 opened this issue May 21, 2019 · 2 comments
Open

PxPay request returnUrl encoding. #57

dm1tr1 opened this issue May 21, 2019 · 2 comments

Comments

@dm1tr1
Copy link

dm1tr1 commented May 21, 2019

Changes from the closed PR #38 also appear in the merged PR #33.

@mediabeastnz
Copy link

I think we're seeing this issue with responses returning the encoded data.
For example the response we get back is encoded like & which has potential to break systems that rely on GET parameters.

@judgej
Copy link
Member

judgej commented Aug 9, 2022

Looks like htmlentities() function here. That's wrong. The getReturnUrl() function should return a simple URL string, not encoded for any particular use.

Until this is fixed, you can reverse it using html_entity_decode() (but maybe check for the presence of & entites first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants