Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on windows 7 due to Directory Separator #71

Closed
electricjones opened this issue Feb 19, 2015 · 2 comments
Closed

Tests fail on windows 7 due to Directory Separator #71

electricjones opened this issue Feb 19, 2015 · 2 comments

Comments

@electricjones
Copy link
Contributor

I pulled a fresh copy of the repo and ran the tests, but got seven failed tests right off the bat.
Six of the failures were from the same root problem. Directory Separators are different in windows.

1) League\Plates\EngineTest::testGetTemplatePath
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'vfs://templates\template.php'
+'vfs://templates/template.php'

3) League\Plates\Template\NameTest::testGetPath
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'vfs://templates\template.php'
+'vfs://templates/template.php'

4) League\Plates\Template\NameTest::testGetPathWithFolder
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'vfs://templates/folder\template.php'
+'vfs://templates/folder/template.php'

5) League\Plates\Template\NameTest::testGetPathWithFolderFallback
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'vfs://templates\fallback.php'
+'vfs://templates/fallback.php'

6) League\Plates\Template\TemplateTest::testGetPath
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'vfs://templates\template.php'
+'vfs://templates/template.php'

7) League\Plates\Template\TemplateTest::testRenderDoesNotExist
Failed asserting that exception message 'The template "template" could not be found at "vfs://templates\template.php".' contains 'The template "template" could not be found at "vfs://templates/template.php".'.
@electricjones
Copy link
Contributor Author

I issued PR #70 as one option to correct this.

@reinink
Copy link
Contributor

reinink commented Dec 27, 2016

I'm going to close this for now until we have a way to run our tests on Windows. At this point I don't think anything is actually broken with the library, just the tests.

@reinink reinink closed this as completed Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants