Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in Config #31

Closed
rosstuck opened this issue Nov 16, 2016 · 3 comments
Closed

Regressions in Config #31

rosstuck opened this issue Nov 16, 2016 · 3 comments

Comments

@rosstuck
Copy link
Member

After merging several large changes, there's a number of issues popping up with bundle config.

For example, the config currently assumes default_bus is always set and errors out if it doesn't. There's no test checking this.

After resolving that, it fails out because the commandbus index isn't seen because it's one level lower in a repeating array now. I'm sure there's more issues that need to be resolved if I keep digging.

These appear in a fresh symfony project setup, not when working on the bundle in isolation. They all need to be fixed before tagging a release.

@tyx
Copy link
Contributor

tyx commented Nov 23, 2016

In fact, we misused the getExtensionConfig here https://github.com/thephpleague/tactician-bundle/blob/master/DependencyInjection/Compiler/CommandHandlerPass.php#L26

It seems it does not get mergedConfig but only original config set by user. (so without default configuration)

We should register default_bus and other stuff into parameter from the bundle extension I guess, to be able to use them in the CompilerPass.

IMO The best way to test that part still behat. I will be available next week to have a look.

@tyx
Copy link
Contributor

tyx commented Nov 29, 2016

Done in #33

@rosstuck
Copy link
Member Author

rosstuck commented May 7, 2017

Merged.

@rosstuck rosstuck closed this as completed May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants