Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all hardcoded data into JSON files #42

Closed
ThePletch opened this issue Oct 2, 2015 · 2 comments
Closed

Move all hardcoded data into JSON files #42

ThePletch opened this issue Oct 2, 2015 · 2 comments
Assignees
@ThePletch

Comments

@ThePletch
Copy link
Owner

The Helpers module shouldn't have hardcoded strings in it (e.g. the icon URLs). These should be moved into JSON files and imported.
@ThePletch ThePletch self-assigned this Oct 2, 2015
@ThePletch
Copy link
Owner Author

This is part of the Nearby Stations update currently in progress - heavy refactoring to object-oriented code is taking place, alongside a whole lot of moving data to JSON.

To augment this issue a bit, the following hardcoded data should be moved to JSON:

  • Route information (broken up into individual routes to avoid loading several MB of data per page load)
  • Image URLs
  • Route color data (should become part of route data)

@ThePletch
Copy link
Owner Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThePletch ThePletch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThePletch