Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share workspace as a non-root user on the host #103

Closed
d3lb3 opened this issue Jul 2, 2022 · 4 comments
Closed

Share workspace as a non-root user on the host #103

d3lb3 opened this issue Jul 2, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@d3lb3
Copy link

d3lb3 commented Jul 2, 2022

As a daily Exegol user, I often find myself annoyed that the shared workspace is mounted as root on the host filesystem.
Most users probably don't use the root account on their host when working with files, making them chown Exegol-generated files every time they need to be used outside of the container.

I think it would be nice to add an option which let users have a non-root shared folder on their host.
One way to do that would be to change the UID/GUID of the user running inside Exegol, in order to match a host user's UID/GUID (they could be specified as an option in the launcher). This blog post came to the same outcome when trying to address the issue : https://vsupalov.com/docker-shared-permissions.

This would probably require the creation and use an other user in Exegol, as changing the UID/GUID of the root user (actually in use in the container) would most probably break stuff (not sure about this one as I am not a Unix expert).

If you think this change could be interesting for user, I can work on a pull request to convert the whole sources installation files that make use of Exegol root user and directory to a dedicated Exegol user that would have the same rights, but specified UID/GUID to make file sharing with the hosts easier.

@d3lb3 d3lb3 changed the title Shared workspace as a non-root user on the host Share workspace as a non-root user on the host Jul 2, 2022
@ShutdownRepo
Copy link
Member

Thank you for raising this issue. It is in fact a problem. In my opinion, it should be implemented wrapper-wise first and then implemented in the images. Transferring this issue to the wrapper repo

@ShutdownRepo ShutdownRepo transferred this issue from ThePorgs/Exegol-images Jul 6, 2022
@ShutdownRepo ShutdownRepo added the enhancement New feature or request label Jul 6, 2022
@Dramelac
Copy link
Member

Hello,

Thank you for your feedback,

Indeed this problem is one of the areas of improvement of Exegol ( through many other topics) but it is not currently planned to change the UID of the root user in the context exegol for various reasons.

This does not mean that I do not have other ideas to correct the problem and this issue will be addressed in future versions.

@ShutdownRepo
Copy link
Member

Just to add some precision on @Dramelac's answer. This issue will be addressed soon, it's in the priority list and is in active brainstorming.

@Dramelac
Copy link
Member

I pushed in dev branch a first implementation of the permission sharing between exegol and the host.
It needs some testing before closing this issues and the latest nightly image (or execute the command umask 007 on every shell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants