Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Detekt #45

Closed
joanb opened this issue Aug 20, 2019 · 4 comments · Fixed by #47
Closed

Adding Detekt #45

joanb opened this issue Aug 20, 2019 · 4 comments · Fixed by #47
Labels
feature request feature requests; wait for 'approved' label to begin work status: approved issues where contributions are welcome

Comments

@joanb
Copy link

joanb commented Aug 20, 2019 •
edited

I think it would be nice to have detekt code analysis for the Kotlin code.

It would have at least the following beneifts:

  • Code style standarization
  • Typical static code analysis stuff: complexity, code smells, etc
  • Easier to digest code reviews
  • Ensure a minimum of quality

For that being posible, it would be nice to trigger detekt when a PR is generated, and prevent it from being merged until the static analysis marks it as good.

If interested, I would gladly start doing a first version of the configuration :)
@maestromac maestromac added the feature request feature requests; wait for 'approved' label to begin work label Sep 4, 2019
@triage-new-issues triage-new-issues bot removed the triage label Sep 4, 2019
@maestromac
Copy link
Contributor

Yes! this would be great

@maestromac maestromac added the status: approved issues where contributions are welcome label Sep 4, 2019
@sierisimo
Copy link
Contributor

Detekt is a great tool and adding configurations is really smooth. If some help is needed, count me in!

@xuhaibahmad
Copy link
Contributor

Haven't seen any progress on this one yet. Is it okay if I create a PR for this?

@xuhaibahmad xuhaibahmad mentioned this issue Sep 9, 2019
Merged
4 tasks
@joanb
Copy link
Author

joanb commented Sep 11, 2019 •
edited

Sorry I was on vacation. I'm glad it's been approved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request feature requests; wait for 'approved' label to begin work status: approved issues where contributions are welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add detekt static analysis xuhaibahmad/DEV-Android
4 participants
@sierisimo @joanb @xuhaibahmad @maestromac