Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore bump #112

Merged
merged 4 commits into from Nov 16, 2020
Merged

.gitignore bump #112

merged 4 commits into from Nov 16, 2020

Conversation

fdocr
Copy link
Contributor

@fdocr fdocr commented Nov 16, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Adds a wildcard option to .gitignore in order to ignore unnecessary IDE local configs

[optional] What gif best describes this PR or how it makes you feel?

broom cleanup

maestromac
maestromac previously approved these changes Nov 16, 2020
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our convo, I think we could apply what we see at https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore to our gitignore

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

@fdocr
Copy link
Contributor Author

fdocr commented Nov 16, 2020

@maestromac I just added the missing values from the .gitignore sample mentioned above. I only left out the ones that don't apply to our case (like the Mongo Explorer plugin, JIRA plugin, etc). Let me know if there's anything else we could include

Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maestromac maestromac merged commit 1671ad8 into master Nov 16, 2020
@fdocr fdocr deleted the fdoxyz/gitignore-bump branch November 16, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants