Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades #42

Merged
merged 3 commits into from Jul 8, 2019
Merged

Dependency upgrades #42

merged 3 commits into from Jul 8, 2019

Conversation

msfjarvis
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Updates Gradle to 5.5 and Kotlin to 1.3.41

Related Tickets & Documents

None

@msfjarvis msfjarvis changed the title [WIP] Dependency upgrades Dependency upgrades Jul 5, 2019
@maestromac
Copy link
Contributor

Hey @MSF-Jarvis can you please resolve the merge conflict?

Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
@msfjarvis
Copy link
Contributor Author

Hey @MSF-Jarvis can you please resolve the merge conflict?

Done, also added in a small improvement to the kts migration.

Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@maestromac maestromac merged commit 83b12fd into forem:master Jul 8, 2019
@msfjarvis msfjarvis deleted the msf/dependency-upgrades branch July 8, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants