Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable backup #71

Merged
merged 2 commits into from Apr 22, 2020
Merged

Disable backup #71

merged 2 commits into from Apr 22, 2020

Conversation

maestromac
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Configuration

Description

Due to the nature of our webview app, we have no need for the build-in backup.

Related Tickets & Documents

n/a

@maestromac maestromac requested a review from fdocr April 21, 2020 21:59
fdocr
fdocr approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@fdocr fdocr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

citizen428
citizen428 approved these changes Apr 22, 2020
View reviewed changes
Copy link

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was in relation to our recent security issue related discussion, right? Thanks for taking care of it!

@maestromac maestromac merged commit d1e55c9 into forem:master Apr 22, 2020
@maestromac maestromac deleted the mac/misc/turn-off-backup branch April 22, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 approved these changes

@fdocr fdocr fdocr approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maestromac @citizen428 @fdocr