Some cleanup and enhancements to the Native Audio implementation #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR drops
MediaSessionConnectorbecause it seems to be buggy in certain platforms like Samsung. The problem I experienced with the lock screen controls is discussed in this thread.The notification controls feel good enough for managing the playback even with the screen locked. This PR subclasses the
PlayerNotificationManagerto include support for rewind/fast-forward.Also drops the complete ExoPlayer package as dependency and only includes the necessary components to reduce app size.
Related Tickets & Documents
This PR enhances the implementation from #72
Screenshots/Recordings (if there are UI changes)
When the screen is locked you can "pull down" to open the notifications and the rewind, play/pause and fast-forward buttons are available:
[optional] What gif best describes this PR or how it makes you feel?