Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate .gitignore files and contents merged into one root #80

Merged
merged 2 commits into from May 27, 2020

Conversation

Rec0iL99
Copy link
Contributor

@Rec0iL99 Rec0iL99 commented May 26, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

I removed all of the duplicate .gitignore files and merged it into one root .gitignore.
Removed .gitignore files include:

  • app/.gitignore
  • data/.gitignore
  • baseui/.gitignore
  • buildSrc/.gitignore

Fixes issue #78

@CLAassistant
Copy link

CLAassistant commented May 26, 2020

CLA assistant check
All committers have signed the CLA.

@Rec0iL99
Copy link
Contributor Author

@fdoxyz also the .idea/misc.xml file is being changed automatically when I do a git status.
It can be solved by ignoring all .idea files.
Should I make a new commit in this branch or open a new PR for this issue?

Copy link
Contributor

@fdocr fdocr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Rec0iL99!

Yes, I think a separate PR for the .idea folder would be best. I'm note entirely sure how that will affect the project, it may or may not be the best thing to ignore it (a quick google search has shown me different points of view).

Anyways I'm in favor of ignoring it if it won't affect negatively, we can have that discussion in another PR.

@fdocr fdocr merged commit 724a12d into forem:master May 27, 2020
@Rec0iL99 Rec0iL99 deleted the chore-duplicate-gitignore branch May 27, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants