Includes error url to override for twitter authentication #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When authenticating with Twitter is important include the urls in the override list for
CustomWebViewClient. When someone fails to authenticate with Twitter the error url that Twitter uses is not included in this list, this causes the modalCustomWebChromeClientto open modally and this breaks the "encapsulation".Related Tickets & Documents
Resolves #82
Screenshots/Recordings (if there are UI changes)
Before (modally presented with
CustomWebChromeClient)After (presented within
CustomWebViewClient)[optional] What gif best describes this PR or how it makes you feel?