Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paired underscores in a username prevents @-mention linking properly #1491

Closed
pkfrank opened this issue Jan 8, 2019 · 7 comments · Fixed by #2948
Closed

Paired underscores in a username prevents @-mention linking properly #1491

pkfrank opened this issue Jan 8, 2019 · 7 comments · Fixed by #2948
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@pkfrank
Copy link
Contributor

pkfrank commented Jan 8, 2019

Describe the bug
I tried to @-mention the user _morgan_adams_ (DEV profile) and noticed this issue. Instead of auto-linking to the DEV profile properly, it interprets the underscores as Markdown instructions to italicize. This is an issue both in both comments and posts.

To Reproduce
See GIF below.

Expected behavior
The @-mentioned username should link to the DEV account properly.

Screenshots
example GIF showing the issue in action

@Zhao-Andy Zhao-Andy added the bug always open for contribution label Jan 9, 2019
@triage-new-issues triage-new-issues bot removed the triage label Jan 9, 2019
@jessleenyc jessleenyc added the external contributors welcome contribution is welcome! label Jan 11, 2019
@Defman21
Copy link
Contributor

IIRC Redcarpet allows you to disable markdown inside words, e.g. some_cool_stuff will be some_cool_stuff, not some cool stuff

@ilonacodes
Copy link

@pkfrank you can use backslash to escape underscore in markdown like @\_morgan_adams_. I just tried on dev.to and it seems to work.

@chase-stevens
Copy link

Backslash works for me as well per @ilonacodes comment. Is this a bug or expected behavior?

@maestromac
Copy link
Contributor

We aren't expecting our users to have to manually escape those underscore so I'd say this is a bug.

@mariocsee
Copy link
Contributor

If no one is working on this, I think I can take it.

My hunch is that there has to be a check disabling some markdown rules in markdown_fixer.rb for words that start with @ since it's used for mentioning, but will continue tomorrow.

@claracodes
Copy link
Contributor

@mariocsee Are you still on it? I think I would like to have a look at it!

@mariocsee
Copy link
Contributor

@ClaraMorgen I ended up working on something else then. Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants