Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging user accounts should be done in a transaction #2230

Closed
lightalloy opened this issue Mar 28, 2019 · 4 comments
Closed

Merging user accounts should be done in a transaction #2230

lightalloy opened this issue Mar 28, 2019 · 4 comments
Labels
external contributors welcome contribution is welcome! type: optimization code and performance optimizations

Comments

@lightalloy
Copy link
Contributor

I think that for a safer merge at least some of the actions should be done inside a db transaction.

https://github.com/thepracticaldev/dev.to/blob/7c1418a87c654c2feb56124c2f750ee5a8455f12/app/services/moderator/merge_user.rb#L15-L26
@maestromac maestromac added type: optimization code and performance optimizations and removed feature request labels Mar 28, 2019
@maestromac
Copy link
Member

Really good idea @lightalloy

@ConSou
Copy link
Contributor

ConSou commented Apr 1, 2019

Hello, I can work on this if its still up for grabs.

@ConSou ConSou mentioned this issue Apr 1, 2019
Merged
7 tasks
@rhymes
Copy link
Contributor

rhymes commented Apr 17, 2019

@lightalloy I think this can be closed 🎉

@lightalloy
Copy link
Contributor Author

Done in #2281

@dependabot-preview dependabot-preview bot mentioned this issue May 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external contributors welcome contribution is welcome! type: optimization code and performance optimizations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lightalloy @rhymes @jessleenyc @maestromac @ConSou